feat: add nanminmax package to handle NaN values #5995

abhishekblue · 2025-03-12T14:48:06Z

Resolves #5579

Description

What is the purpose of this pull request?

This pull request:

introduces the @stdlib/stats/incr/nanminmax package, which incrementally computes minimum and maximum, ignoring NaN values.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: add stats/incr/nanminmax #5579

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

stdlib-bot · 2025-03-12T14:49:44Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanminmax	$\color{green}146/146$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}146/146$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Neerajpathak07 · 2025-03-13T17:13:34Z

@abhishekblue So, for every example the return value is:- [ -5, 5 ] even if the input values are different.
This would be primarily because the main.js implementation isn't in-line I'd recommend you to go through it again.
you can also run eslint locally to check for any errors.

abhishekblue · 2025-03-13T17:32:08Z

@Neerajpathak07 I have checked tests again, also checked by logging the values of the examples it works fine, also checked modules as well. Any other suggestions?

Neerajpathak07 · 2025-03-13T17:43:26Z

@abhishekblue Ig you did everything except giving the main.js file a brief look. since we are testing the values for accumulator function and it is coming inconsistent then definitely the function isn't correct.

lib/node_modules/@stdlib/stats/incr/nanminmax/lib/main.js

lib/node_modules/@stdlib/stats/incr/nanminmax/README.md

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter · 2025-09-27T20:07:28Z

/stdlib merge

Signed-off-by: Philipp Burckhardt <[email protected]>

feat: add nanminmax package to handle NaN values

511d980

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Mar 12, 2025

abhishekblue marked this pull request as ready for review March 12, 2025 15:02

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 12, 2025

update main.js

f71eed2